Update linters to conform to ShakaCode standards #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwise
force-pushed
the
update-linters
branch
from
2bddb80 to
d6c689c
Compare
.eslintrc
Outdated
robwise
force-pushed
the
update-linters
branch
from
3934225 to
931692b
Compare
|
@dylangrafmyre I'm pretty sure we're failing the linters in CI because of needing to update our eslint dependencies. I pass with the latest version of eslint (v1.10.1) locally, but the docker container is shrinkwrapped to v1.6.0. How do I go about updating this? |
|
@robwise just need to update the package.json and npm shrinkwrap followed by a push to origin(shakacode/docker-lint). This will trigger a new build of the container image on Docker Hub. And when CI runs it will pull down the latest build. I can help with this if needed? |
|
Thanks @dylangrafmyre for helping me on this! We had to update the linter dependencies in the docker image. This should be good to go pending a final review. |
|
Looks good. Let's merge. |
|
@robwise Did you confirm that the generated code passes these linter changes? |
|
@justin808 affirmative, good to go |
This change is in parallel with the change made for the webpack tutorial. See shakacode/react-webpack-rails-tutorial#159 - Fix generator linters templating logic for scss task - Remove unnecessary lodash import in generated loggerMiddleware - Exclude dummy apps from linting - Remove unnecessary 'refs' attribute in generated component - Add dummy apps to eslintignore
robwise
force-pushed
the
update-linters
branch
from
9de48e4 to
3573d80
Compare
robwise
added a commit
that referenced
this pull request
Nov 23, 2015
Update linters to conform to ShakaCode standards
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 25, 2025
* Add option to SUPPORT_MODULES for loadable-components Add require to the vm context Add doc about SSR with loadable-components Module wrap instead of passing require in context Add upload asset route Remove library target option from vm-renderer JS tests pass Ensure handling of async errors with Express JS test pass https://github.com/Abazhenov/express-async-handler https://medium.com/@Abazhenov/using-async-await-in-express-with-node-8-b8af872c0016 https://github.com/Abazhenov/express-async-handler#readme update ruby for circle ci to 2.7 Remove dir creation in config reading Change sync to async/await Added locking to uploading assets Adjust bundler version Changed name of ISOLATED_VM to SUPPORT_MODULES Update to Bundler v2 Co-authored-by: Andrey Ashgaliyev <[email protected]>
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 26, 2025
* Add option to SUPPORT_MODULES for loadable-components Add require to the vm context Add doc about SSR with loadable-components Module wrap instead of passing require in context Add upload asset route Remove library target option from vm-renderer JS tests pass Ensure handling of async errors with Express JS test pass https://github.com/Abazhenov/express-async-handler https://medium.com/@Abazhenov/using-async-await-in-express-with-node-8-b8af872c0016 https://github.com/Abazhenov/express-async-handler#readme update ruby for circle ci to 2.7 Remove dir creation in config reading Change sync to async/await Added locking to uploading assets Adjust bundler version Changed name of ISOLATED_VM to SUPPORT_MODULES Update to Bundler v2 Co-authored-by: Andrey Ashgaliyev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in parallel with the change made for the webpack
tutorial.
See shakacode/react-webpack-rails-tutorial#159